Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dtype-next provides config for nippy #67

Closed
borkdude opened this issue Oct 20, 2022 · 6 comments
Closed

dtype-next provides config for nippy #67

borkdude opened this issue Oct 20, 2022 · 6 comments

Comments

@borkdude
Copy link

Hi @cnuernber!

Thanks for providing a clj-kondo config for your library users, much appreciated. I found one peculiarity today in someone's project:

Screenshot 2022-10-20 at 20 12 21

In this particular case I stumbled upon an issue in someone's project and it was hard to track down where this came from since I didn't expect dtype next to provide a clj-kondo configuration for nippy.

Libraries should probably not provide configuration for other libraries that they don't own.

Thanks again,

Michiel

@borkdude
Copy link
Author

@cnuernber In particular this construct caused the "unused value", since type is a "pure" function:

The dt argument could probably also be ignored, right?

@cnuernber
Copy link
Owner

Both points I think are valid - the type there was a debug helper that didn't get fully removed. That being said I myself don't use any kondo-based tools so I have not been maintaining or testing this integration and no one else has stepped up to do so so I think there are two options really - fix just this with a PR or remove it.

@borkdude
Copy link
Author

I think we can move the nippy config here:

https://github.com/clj-kondo/configs

which is a repo to host configs for third party libraries via dependencies that people can include in their deps.edn.

I'll add it over there and you can remove (only the nippy!) config here.

@cnuernber
Copy link
Owner

Great! Will do.

@borkdude
Copy link
Author

@cnuernber
Copy link
Owner

That config is gone from this project :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants