From 5b8277a0fb37faac2ebe5247dd1a21b265e48c0a Mon Sep 17 00:00:00 2001 From: Nikhil Benesch Date: Wed, 2 Aug 2017 17:03:27 -0400 Subject: [PATCH 1/3] CODEOWNERS: sink to empty set, not nonexistent team This works as intended. --- .github/CODEOWNERS | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 31c4939130ed..f0fe1f7d3f92 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -41,11 +41,10 @@ /pkg/sql/distsqlplan/ @cockroachdb/distsql @cockroachdb/sql-planning /pkg/sql/distsqlrun/ @cockroachdb/distsql @cockroachdb/sql-execution -# We purposefully sink testlogic into a non-existent team to disable -# notifications otherwise caught by the @sql-rest team. Typically, -# testlogic changes are part of a bigger change that will trigger -# notifications to the correct sub-team. -/pkg/sql/testlogic/ @cockroachdb/nonexistent +# We purposefully disable testlogic notifications to disable notifications +# otherwise caught by the @sql-rest team. Typically, testlogic changes are part +# of a bigger change that will trigger notifications to the correct sub-team. +/pkg/sql/testlogic/ /pkg/ui/ @cockroachdb/admin-ui From dda0e78b37ae3735881c58c69a64333393a9db35 Mon Sep 17 00:00:00 2001 From: Nikhil Benesch Date: Wed, 2 Aug 2017 17:05:06 -0400 Subject: [PATCH 2/3] CODEOWNERS: associate pkg/storage with core --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f0fe1f7d3f92..233e54c104e2 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -12,6 +12,7 @@ /pkg/roachpb/ @cockroachdb/core /pkg/rpc/ @cockroachdb/core /pkg/server/ @cockroachdb/core +/pkg/storage/ @cockroachdb/core /pkg/migration/ @cockroachdb/core @cockroachdb/sql /pkg/ccl/ @cockroachdb/sql-ccl From 78644f30ef13da822fac0f719c0acb99e1b3f940 Mon Sep 17 00:00:00 2001 From: Nikhil Benesch Date: Wed, 2 Aug 2017 15:41:35 -0400 Subject: [PATCH 3/3] CODEOWNERS: ignore generated files in the UI Touching any .proto will generate changes in these files. --- .github/CODEOWNERS | 75 ++++++++++++++++++++++++---------------------- 1 file changed, 39 insertions(+), 36 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 233e54c104e2..3ee077d60fb2 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -6,57 +6,60 @@ # # Remember, *the last rule to match wins.* -/pkg/gossip/ @cockroachdb/core -/pkg/internal/ @cockroachdb/core -/pkg/kv/ @cockroachdb/core -/pkg/roachpb/ @cockroachdb/core -/pkg/rpc/ @cockroachdb/core -/pkg/server/ @cockroachdb/core -/pkg/storage/ @cockroachdb/core -/pkg/migration/ @cockroachdb/core @cockroachdb/sql +/pkg/gossip/ @cockroachdb/core +/pkg/internal/ @cockroachdb/core +/pkg/kv/ @cockroachdb/core +/pkg/roachpb/ @cockroachdb/core +/pkg/rpc/ @cockroachdb/core +/pkg/server/ @cockroachdb/core +/pkg/storage/ @cockroachdb/core +/pkg/migration/ @cockroachdb/core @cockroachdb/sql -/pkg/ccl/ @cockroachdb/sql-ccl -/pkg/cli/ @cockroachdb/sql-ui +/pkg/ccl/ @cockroachdb/sql-ccl +/pkg/cli/ @cockroachdb/sql-ui -/pkg/sql/ @cockroachdb/sql-rest +/pkg/sql/ @cockroachdb/sql-rest -/pkg/sql/parser/ @cockroachdb/sql-language -/pkg/sql/ir/ @cockroachdb/sql-language +/pkg/sql/parser/ @cockroachdb/sql-language +/pkg/sql/ir/ @cockroachdb/sql-language -/pkg/sql/pgwire/ @cockroachdb/sql-wiring -/pkg/sql/privilege/ @cockroachdb/sql-wiring @cockroachdb/sql-language @cockroachdb/sql-execution +/pkg/sql/pgwire/ @cockroachdb/sql-wiring +/pkg/sql/privilege/ @cockroachdb/sql-wiring @cockroachdb/sql-language @cockroachdb/sql-execution -/pkg/sql/sqlbase/ @cockroachdb/sql-planning @cockroachdb/sql-execution @cockroachdb/sql-async +/pkg/sql/sqlbase/ @cockroachdb/sql-planning @cockroachdb/sql-execution @cockroachdb/sql-async -/pkg/sql/*.go @cockroachdb/sql-planning @cockroachdb/sql-execution +/pkg/sql/*.go @cockroachdb/sql-planning @cockroachdb/sql-execution -/pkg/sql/executor* @cockroachdb/sql-execution -/pkg/sql/mon/ @cockroachdb/sql-execution +/pkg/sql/executor* @cockroachdb/sql-execution +/pkg/sql/mon/ @cockroachdb/sql-execution /pkg/sql/sqlutil/*executor* @cockroachdb/sql-execution -/pkg/sql/schema* @cockroachdb/sql-async -/pkg/sql/lease* @cockroachdb/sql-async -/pkg/sql/jobs/ @cockroachdb/sql-async +/pkg/sql/schema* @cockroachdb/sql-async +/pkg/sql/lease* @cockroachdb/sql-async +/pkg/sql/jobs/ @cockroachdb/sql-async -/pkg/sql/distsql*.go @cockroachdb/distsql @cockroachdb/sql-planning -/pkg/sql/distsqlplan/ @cockroachdb/distsql @cockroachdb/sql-planning -/pkg/sql/distsqlrun/ @cockroachdb/distsql @cockroachdb/sql-execution +/pkg/sql/distsql*.go @cockroachdb/distsql @cockroachdb/sql-planning +/pkg/sql/distsqlplan/ @cockroachdb/distsql @cockroachdb/sql-planning +/pkg/sql/distsqlrun/ @cockroachdb/distsql @cockroachdb/sql-execution # We purposefully disable testlogic notifications to disable notifications # otherwise caught by the @sql-rest team. Typically, testlogic changes are part # of a bigger change that will trigger notifications to the correct sub-team. /pkg/sql/testlogic/ -/pkg/ui/ @cockroachdb/admin-ui +/pkg/ui/ @cockroachdb/admin-ui +/pkg/ui/embedded.go +/pkg/ui/src/js/protos.d.ts +/pkg/ui/src/js/protos.js -/build/ @cockroachdb/build -/c-deps/ @cockroachdb/build -/githooks/ @cockroachdb/build -/scripts/ @cockroachdb/build -**/Makefile @cockroachdb/build -/Gopkg.* @cockroachdb/build -/.* @cockroachdb/build -/.github/ @cockroachdb/build +/build/ @cockroachdb/build +/c-deps/ @cockroachdb/build +/githooks/ @cockroachdb/build +/scripts/ @cockroachdb/build +**/Makefile @cockroachdb/build +/Gopkg.* @cockroachdb/build +/.* @cockroachdb/build +/.github/ @cockroachdb/build -/c-deps/libroach/ @cockroachdb/core -/c-deps/libroach/ccl/ @cockroachdb/core @cockroachdb/sql-ccl +/c-deps/libroach/ @cockroachdb/core +/c-deps/libroach/ccl/ @cockroachdb/core @cockroachdb/sql-ccl