Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sql: asynchronous ALTER TABLE name [ADD|DROP] COLUMN ... #2035

Closed
petermattis opened this issue Aug 10, 2015 · 2 comments
Closed

sql: asynchronous ALTER TABLE name [ADD|DROP] COLUMN ... #2035

petermattis opened this issue Aug 10, 2015 · 2 comments
Assignees
Milestone

Comments

@petermattis
Copy link
Collaborator

Lots of work to make this happen. Adding a non-unique column should be a straightforward change to the TableDescriptor. Adding a unique column would also require adding a unique index which will require the infrastructure for the multi-step process of:

  • Adding the index to the TableDescriptor but marking it as write-only.
  • Waiting for the TableDescriptor change to propagate to all of the nodes.
  • Backfilling the index with some sort of mapreduce over the table.
  • Marking the index as read-write in the TableDescriptor.

Dropping a column (assuming it is not referenced by an index) will also be a multi-step process:

  • Marking the column as deleting in the TableDescriptor.
  • Waiting for the TableDescriptor change to propagate to all of the nodes.
  • Deleting the column with some sort of mapreduce over the table.
  • Removing the column from the TableDescriptor.
@petermattis petermattis added this to the v0.1 (Beta) milestone Aug 14, 2015
@tbg tbg added the SQL label Aug 15, 2015
@jess-edwards jess-edwards mentioned this issue Aug 17, 2015
78 tasks
@petermattis
Copy link
Collaborator Author

If you'd like, I can do the grammar changes required for this.

@tamird tamird changed the title sql: add support for ALTER TABLE name [ADD|DROP] COLUMN ... asynchronous ALTER TABLE name [ADD|DROP] COLUMN ... Oct 26, 2015
@tamird tamird changed the title asynchronous ALTER TABLE name [ADD|DROP] COLUMN ... sql: asynchronous ALTER TABLE name [ADD|DROP] COLUMN ... Oct 26, 2015
@tamird
Copy link
Contributor

tamird commented Nov 7, 2015

The remaining work here is tracked by #2845.

@tamird tamird closed this as completed Nov 7, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants