From 3093b9734151c42faaf9e51bf0e4bea5ade5b127 Mon Sep 17 00:00:00 2001 From: Tobias Grieger Date: Thu, 28 Nov 2024 15:04:50 +0100 Subject: [PATCH] envconfig: default GRPC_ENFORCE_ALPN_ENABLED to false CRDB at v1.68.0 fails to communicate with CRDB at v1.56.3 due to this check. This is strange, since CRDB uses gRPC throughout, and in both v1.56.3 and v1.68.0 uses `tls.NewConfig` which ensures that `NextProtos` always contains `h2`. gRPC introduced this check in https://github.com/grpc/grpc-go/pull/7535. See: https://github.com/cockroachdb/cockroach/pull/136278#issuecomment-2506167509 --- internal/envconfig/envconfig.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/envconfig/envconfig.go b/internal/envconfig/envconfig.go index 6e7dd6b77270..e323b3703b33 100644 --- a/internal/envconfig/envconfig.go +++ b/internal/envconfig/envconfig.go @@ -45,7 +45,7 @@ var ( // option is present for backward compatibility. This option may be overridden // by setting the environment variable "GRPC_ENFORCE_ALPN_ENABLED" to "true" // or "false". - EnforceALPNEnabled = boolFromEnv("GRPC_ENFORCE_ALPN_ENABLED", true) + EnforceALPNEnabled = boolFromEnv("GRPC_ENFORCE_ALPN_ENABLED", false) // XDSFallbackSupport is the env variable that controls whether support for // xDS fallback is turned on. If this is unset or is false, only the first // xDS server in the list of server configs will be used.