Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make an exception for "Start from beginning" for the url-parameter t(ime) #2061

Closed
ShalokShalom opened this issue Mar 3, 2024 · 4 comments
Closed
Assignees
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure.

Comments

@ShalokShalom
Copy link

"Force video to start from beginning" does allow to avoid videos to be played from previous states.

So, when we leave one video, we dont want it to be played from that exact position anymore.

But, that feature has an unintended side effect: This link is supposed to jump to 2:19:20

As you can see, there is a dedicated timestamp in the URL. It is used, to send someone a link to a specific position, which is practical if you want to show your friend a certain scene in a 2 hour long video.

I do suggest that we create an exception for such links, and only set back videos, who have the position saved from previous sessions.

@ShalokShalom ShalokShalom added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Mar 3, 2024
@ImprovedTube ImprovedTube added the Completion / Revision Rethink, complete, improve, tweak our feature or structure. label Mar 4, 2024
@ImprovedTube ImprovedTube changed the title Make an exception for "Start from beginning" Make an exception for "Start from beginning" for the url-parameter t(ime) Mar 4, 2024
@ImprovedTube ImprovedTube removed the Feature request Wish or idea label Mar 4, 2024
@raszpl
Copy link
Contributor

raszpl commented Mar 4, 2024

#2062 should fix it, but Im unable to test it fully because I cant trigger YT to serve me video continuing to play from last timestamp. Iv seen this work on other computers - when someone watches YT and shuts down whole computer, next time browser is started it remembers position, but this doesnt happen on my instance for some reason.

@raszpl raszpl self-assigned this Mar 4, 2024
@raszpl raszpl removed help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* Completion / Revision Rethink, complete, improve, tweak our feature or structure. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Mar 4, 2024
@ImprovedTube ImprovedTube added the Completion / Revision Rethink, complete, improve, tweak our feature or structure. label Mar 6, 2024
@raszpl
Copy link
Contributor

raszpl commented Mar 8, 2024

So Iv been thinking, what exactly is the purpose of "Force video to play from the beginning" in the first place?

For example playing some video, then going to YT preferences and Changing Theme leads to viedo page being refreshed to URL
https://www.youtube.com/watch?v=mrbFpLwLQAk&themeRefresh=1&time_continue=8
followed by
https://www.youtube.com/watch?v=mrbFpLwLQAk&t=8s

With my patch this will result in video being restarted from the start, not good. I would like to see how YT is accomplishing that continue from last time you left functionality, I wouldnt be surprised if its also done with &t= in which case my patch just broke "Force video to play from the beginning" instead of making an exception :(

@ImprovedTube
Copy link
Member

&themeRefresh=1&time_continue=8

rare enough(?)
And the regex can cover that too.

what exactly is the purpose of "Force video to play from the beginning" in the first place?

people not wanting to remember where they left? music? @ShalokShalom
not being sure either might make me move it down in the list (unless we start counting popularity of each feature earlier)

@ShalokShalom
Copy link
Author

Yeah, having music videos picked up where I left, is super annoying.

This alone is worth installing this extension for me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure.
Projects
Status: Done
Development

No branches or pull requests

3 participants