testing: migration to jest #90

przemyslaw-rzasa · 2021-12-15T13:40:43Z

przemyslaw-rzasa · 2021-12-16T13:13:05Z

.gitignore

@@ -18,3 +18,6 @@ yarn.lock
 # Mac OSX Finder files.
 **/.DS_Store
 .DS_Store
+
+# Configs
+!jest.config.js


Created as js by default by ts-jest. Prompting works thanks to specific type annotation on the top of the file.

przemyslaw-rzasa · 2021-12-16T13:15:45Z

cli/cli.js

@@ -1,15 +1,18 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {


Caused by esModuleInterop. Shouldn't have negative impact.

jest.config.js

przemyslaw-rzasa · 2021-12-16T13:26:00Z

schematics/cloud/authentication/cognito/data/expected-new-files.json

@@ -0,0 +1,6 @@
+[


Previously these expectedFiles has been imported / exported directly between the test files. Right after switch to jest due to that many tests has been running multiple times and has been giving really nasty errors.

We should keep our tests as isolated as possible, to I'd suggest to always create separate file for sharable data.

przemyslaw-rzasa · 2021-12-16T13:28:04Z

schematics/cloud/authentication/cognito/index.ts

@@ -65,7 +65,6 @@ export const cloudAuthenticationCognitoGenerator = (options: Schema): Rule => {
      options.emails
        ? schematic(CloudSchematic.AUTHENTICATION_EMAILS, { name })
        : noop(),
-      schematic("apply-prettier", {}),


apply-prettier used once at the end of the main schematic should be enough I believe

AFAIK plan is to be able to apply some features (e.g. add authentication) to an existing application. In this case some specific schematic (not top level application schematic) will be executed, so probably it is need for those scenarios. Is that right @pieralukasz?

Okay, will bring them back. Thanks for this info

przemyslaw-rzasa · 2021-12-16T13:30:12Z

.gitignore

@@ -18,3 +18,6 @@ yarn.lock
 # Mac OSX Finder files.


I'd suggest to check this file and it's dependencies firstly

przemyslaw-rzasa · 2021-12-16T13:37:55Z

test/setupJestAfterEnv.ts

+       *
+       * Useful for check, if schematics has created exactly same list of files as expected (ignores order).
+       */
+      toHaveEqualElements(expected: Primitive[]): R;


Replacement for jasmine.arrayWithExactContent, but we don't have to care about the order anymore.

przemyslaw-rzasa · 2021-12-16T13:39:08Z

test/setupJestAfterEnv.ts

+       *
+       * Useful for check, if schematics has created expected files.
+       */
+      toIncludeEvery(expected: Primitive[]): R;


Finally I've gave up with usage of it, as this leaves too much place for an errors. Left it, as might be suitable in the future. But can be deleted if you wish, no strong feelings here.

Let's keep it for now, will delete it later if not used

przemyslaw-rzasa · 2021-12-16T13:40:30Z

test/setupJestAfterEnv.ts

+       *
+       * Useful for check, if schematics **does NOT** create any not expected files.
+       */
+      toIncludeSome(expected: Primitive[]): R;


Created for test cases, which proves that files from specific module haven't been created.

przemyslaw-rzasa · 2021-12-16T13:50:32Z

schematics/cloud/janush/index_spec.ts

 describe("cloud.janush", () => {
-  it("should generate all janush files properly", async () => {
+  it("should create files for: [template, janush]", async () => {


As in most cases schematics are dependent on each other, maybe in a tests description we should mention about all the schematics which are in a current stack [?]

przemyslaw-rzasa · 2021-12-16T14:11:51Z

schematics/cloud/authentication/cognito/index_spec.ts

-    spyOn(janush, "readJanushJSON").and.returnValue(emptyJanush);
-    spyOn(janush, "updateJanushJSON");
+    jest.spyOn(janush, "readJanushJSON").mockReturnValue(emptyJanush);
+    jest.spyOn(janush, "updateJanushJSON").mockImplementation();


Why .mockImplementation()?

przemyslaw-rzasa · 2021-12-16T16:07:54Z

Comparision

Jasmine

Jest

Jasmine has finished the test suites a bit earlier than jest, but we have to keep in mind that:

it required build command before running the tests itself to run
previously there was lower amount of tests set

As I've been playing with jest configuration I was able to reach jasmine score, but it required to have already built js files which was a bit pointless. Leaving it as it is for now, and if there will be any performance problems in the future, we can always come to this checkpoint 🙃

PS I've also made custom matchers as dummy as possible and removed tests for them, but it had minimal / none impact on the performance, so they seems to work ok.

JacekKosciesza · 2021-12-17T08:40:53Z

schematics/cloud/authentication/cognito/index.ts

@@ -65,7 +65,6 @@ export const cloudAuthenticationCognitoGenerator = (options: Schema): Rule => {
      options.emails
        ? schematic(CloudSchematic.AUTHENTICATION_EMAILS, { name })
        : noop(),
-      schematic("apply-prettier", {}),


AFAIK plan is to be able to apply some features (e.g. add authentication) to an existing application. In this case some specific schematic (not top level application schematic) will be executed, so probably it is need for those scenarios. Is that right @pieralukasz?

JacekKosciesza · 2021-12-17T08:52:42Z

test/setupJestAfterEnv.ts

+       *
+       * Useful for check, if schematics has created expected files.
+       */
+      toIncludeEvery(expected: Primitive[]): R;


Let's keep it for now, will delete it later if not used

przemyslaw-rzasa force-pushed the feature/migration-to-jest branch 4 times, most recently from 3afd7fb to 1d6bb64 Compare December 15, 2021 14:23

Jest integration

ea22e90

przemyslaw-rzasa force-pushed the feature/migration-to-jest branch 2 times, most recently from 3a442f5 to 4e88fdb Compare December 16, 2021 13:08

przemyslaw-rzasa commented Dec 16, 2021

View reviewed changes

jest.config.js Outdated Show resolved Hide resolved

przemyslaw-rzasa commented Dec 16, 2021

View reviewed changes

przemyslaw-rzasa force-pushed the feature/migration-to-jest branch from 4e88fdb to 365d455 Compare December 16, 2021 14:09

przemyslaw-rzasa commented Dec 16, 2021

View reviewed changes

przemyslaw-rzasa force-pushed the feature/migration-to-jest branch 3 times, most recently from 9437465 to bb57b0d Compare December 16, 2021 16:04

Jest integration - part 2

f1ee380

przemyslaw-rzasa force-pushed the feature/migration-to-jest branch from bb57b0d to f1ee380 Compare December 16, 2021 16:11

przemyslaw-rzasa marked this pull request as ready for review December 16, 2021 16:18

przemyslaw-rzasa changed the title ~~feature: migration to jest~~ testing: migration to jest Dec 16, 2021

przemyslaw-rzasa requested review from dejgon, pieralukasz and JacekKosciesza December 17, 2021 08:54

JacekKosciesza approved these changes Dec 17, 2021

View reviewed changes

dejgon approved these changes Dec 17, 2021

View reviewed changes

pieralukasz approved these changes Dec 17, 2021

View reviewed changes

Bring back apply-prettier schematic

6cb7e4c

przemyslaw-rzasa merged commit 722170a into main Dec 17, 2021

przemyslaw-rzasa deleted the feature/migration-to-jest branch December 17, 2021 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

testing: migration to jest #90

testing: migration to jest #90

przemyslaw-rzasa commented Dec 15, 2021

przemyslaw-rzasa Dec 16, 2021 •

edited

Loading

przemyslaw-rzasa Dec 16, 2021

przemyslaw-rzasa Dec 16, 2021

przemyslaw-rzasa Dec 16, 2021

JacekKosciesza Dec 17, 2021

przemyslaw-rzasa Dec 17, 2021

przemyslaw-rzasa Dec 16, 2021

przemyslaw-rzasa Dec 16, 2021

przemyslaw-rzasa Dec 16, 2021

JacekKosciesza Dec 17, 2021 •

edited

Loading

przemyslaw-rzasa Dec 16, 2021

przemyslaw-rzasa Dec 16, 2021

przemyslaw-rzasa Dec 16, 2021

przemyslaw-rzasa commented Dec 16, 2021 •

edited

Loading

JacekKosciesza Dec 17, 2021

JacekKosciesza Dec 17, 2021 •

edited

Loading

		@@ -1,15 +1,18 @@
		"use strict";
		var __importDefault = (this && this.__importDefault) \|\| function (mod) {

testing: migration to jest #90

testing: migration to jest #90

Conversation

przemyslaw-rzasa commented Dec 15, 2021

przemyslaw-rzasa Dec 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JacekKosciesza Dec 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przemyslaw-rzasa commented Dec 16, 2021 • edited Loading

Choose a reason for hiding this comment

JacekKosciesza Dec 17, 2021 • edited Loading

Choose a reason for hiding this comment

przemyslaw-rzasa Dec 16, 2021 •

edited

Loading

JacekKosciesza Dec 17, 2021 •

edited

Loading

przemyslaw-rzasa commented Dec 16, 2021 •

edited

Loading

JacekKosciesza Dec 17, 2021 •

edited

Loading