fix: realtime reporter only set id on non null step.metaStep #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Guys, please publish the new version of the npm package. It's a pity when it is already fixed and merged. Examples are failing in UI now. :( |
|
When this will be published?.. 5 month ago latest upgrade of the package. Can't use this package without this fix |
|
Don't mind my previous (deleted) comment. Thank's for merging and releasing this fix, i looked at the wrong place earlier. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launching test with the latest version of the codecept ui always terminated with an error setting an id on a null metaStep object.
Digging in the source code revealed that an id is generated and assigned to metaStep before checking that it's not null.
Here is a quick fix