Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Configuration clearity #359

Open
SilentImp opened this issue Feb 25, 2021 · 0 comments
Open

Configuration clearity #359

SilentImp opened this issue Feb 25, 2021 · 0 comments
Assignees

Comments

@SilentImp
Copy link

SilentImp commented Feb 25, 2021

Hi, maybe it would be nice to provide more documentation examples and information about default values.
For example I created this config:

---
version: "2"
plugins:
  duplication:
    enabled: true
    config:
      languages:
        - javascript
      checks:
        mass_threshold: 50
        similar-code:
          config:
            threshold: 60
        identical-code:
          config:
            threshold: 40

And its raise some questions:

  • is it correct?
  • why we can't set identical-code: 60 without config: and threshold:?
  • can I set mass_threshold: under checks:?
  • is my config only allow javascript language?

Also maybe it would be really cool to have a way to visually see the threshold level impact with a code example. Something like code block (default, but with a way to paste your own), a couple of sliders and a result. What do you think, can it be useful?

Regards. Anton.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants