Skip to content

Support rubocop-sorbet alongside rubocop-airbnb #264

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
bmulholland opened this issue Dec 1, 2020 · 4 comments
Open

Support rubocop-sorbet alongside rubocop-airbnb #264

bmulholland opened this issue Dec 1, 2020 · 4 comments
Assignees

Comments

@bmulholland
Copy link

Now that typechecking is coming in Ruby 3, sorbet will likely become more popular. https://github.com/shopify/rubocop-sorbet has some rubocop rules for sorbet that would be great to include.

@britneywright
Copy link

britneywright commented Dec 1, 2020

@bmulholland Which version of rubocop are you using? sorbet is in supported in rubocop-0-92
See #261

@bmulholland
Copy link
Author

Huh, I definitely searched for sorbet in this repo before filing the issue. Not sure how I missed that!

In any case, I'm unfortunately using the airbnb channel. Would you accept a PR to add sorbet to that channel?

@britneywright
Copy link

You can try opening a PR. Keep in mind the airbnb plugin has some strict dependencies (https://rubygems.org/gems/rubocop-airbnb) that may make compatibility with other plugins difficult. That's why we had to make a separate channel to support it.

@bmulholland
Copy link
Author

bmulholland commented Dec 2, 2020

Yeah, great point. I upgraded gems on the rubocop-airbnb gem and submitted a PR - let's see if that unblocks things here.

@bmulholland bmulholland changed the title Support rubocop-sorbet Support rubocop-sorbet alongside rubocop-airbnb Dec 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants