Skip to content

RuboCop 1.72 breaks GitHub CodeClimate CI #376

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
JoeCohen opened this issue Mar 1, 2025 · 1 comment
Open

RuboCop 1.72 breaks GitHub CodeClimate CI #376

JoeCohen opened this issue Mar 1, 2025 · 1 comment

Comments

@JoeCohen
Copy link

JoeCohen commented Mar 1, 2025

I am a developer for MushroomObserver (MO), an open-source, all-volunteer nonprofit.

MO is a Ruby on Rails app.
The code repository is GitHub, https://github.com/MushroomObserver/mushroom-observer
We use and rely on both RuboCop for local testing and the CodeClimate GitHub App for CI.

When we upgraded RuboCop to version 1.72, the CodeClimate CI broke. Example: https://codeclimate.com/github/MushroomObserver/mushroom-observer/builds/11148

I believe the breakage relates to the plugin system introduced in v 1.72, in particular, the changed key in the .rubocop.yml file: “require” changed to “plugins”. See https://docs.rubocop.org/rubocop/1.72/extensions.html

  • With plugins: our CI breaks,. while our local RuboCop works fine.
  • With require: it’s the opposite: CI works fine, but local RuboCop breaks.

Note that our .codeclimate.yml includes the rubocop plugin, and we specify the latest channel available from CodeClimate (rubocop-1-56-3). See https://github.com/codeclimate/codeclimate-rubocop/branches/all?utf8=%E2%9C%93&query=channel%2Frubocop

I therefore wonder if:

  • CodeClimate could add a new rubocop channel which fixes the problem.
  • RuboCop could continue to accept require for extension; and/or
    you could suggest a workaround which would let us use the latest RuboCop version both locally and in the CodeClimate GitHub App for CI.
@koic
Copy link

koic commented Mar 1, 2025

A perspective on this is described in rubocop/rubocop#13934, and supporting a RuboCop 1.72 channel in Code Climate would be the fundamental solution to ensuring version consistency.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants