From 39331a6afba5a7fe178e92145dcefe7a647ebfad Mon Sep 17 00:00:00 2001 From: Thomas Kluyver Date: Mon, 3 Jun 2019 22:04:23 +0100 Subject: [PATCH] Run Python coverage tool with shell=False --- codecov/__init__.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/codecov/__init__.py b/codecov/__init__.py index 6fd9f197..c1edd19a 100644 --- a/codecov/__init__.py +++ b/codecov/__init__.py @@ -177,9 +177,9 @@ def check_output(cmd, **popen_args): return output.decode('utf-8') -def try_to_run(cmd): +def try_to_run(cmd, shell=True): try: - return check_output(cmd, shell=True) + return check_output(cmd, shell=shell) except subprocess.CalledProcessError as e: write(' Error running `%s`: %s' % (cmd, str(getattr(e, 'output', str(e))))) @@ -193,10 +193,10 @@ def run_python_coverage(args): import coverage except ImportError: # Coverage is not installed on this Python. Hope it's on PATH. - try_to_run(['coverage'] + args) + try_to_run(['coverage'] + args, shell=False) else: # Coverage is installed on this Python. Run it as a module. - try_to_run([sys.executable, '-m', 'coverage'] + args) + try_to_run([sys.executable, '-m', 'coverage'] + args, shell=False) def remove_non_ascii(data): try: