Skip to content

Commit ffdb5b8

Browse files
Use generic in Xpp3Reader for JDK 5+
1 parent d2ddc56 commit ffdb5b8

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

modello-plugins/modello-plugin-xpp3/src/main/java/org/codehaus/modello/plugin/xpp3/Xpp3ReaderGenerator.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.codehaus.modello.model.ModelDefault;
3737
import org.codehaus.modello.model.ModelField;
3838
import org.codehaus.modello.plugin.java.javasource.JClass;
39+
import org.codehaus.modello.plugin.java.javasource.JCollectionType;
3940
import org.codehaus.modello.plugin.java.javasource.JConstructor;
4041
import org.codehaus.modello.plugin.java.javasource.JField;
4142
import org.codehaus.modello.plugin.java.javasource.JMethod;
@@ -499,7 +500,11 @@ private void writeClassParser(ModelClass modelClass, JClass jClass, boolean root
499500
} else {
500501
// Write other fields
501502

502-
sc.add("java.util.Set parsed = new java.util.HashSet();");
503+
if (hasJavaSourceSupport(5)) {
504+
sc.add("java.util.Set<String> parsed = new java.util.HashSet<String>();");
505+
} else {
506+
sc.add("java.util.Set parsed = new java.util.HashSet();");
507+
}
503508

504509
sc.add("while ( ( strict ? parser.nextTag() : nextTag( parser ) ) == XmlPullParser.START_TAG )");
505510

@@ -1290,7 +1295,8 @@ private JMethod getCheckFieldWithDuplicateMethod() {
12901295
method.addParameter(new JParameter(new JClass("XmlPullParser"), "parser"));
12911296
method.addParameter(new JParameter(new JClass("String"), "tagName"));
12921297
method.addParameter(new JParameter(new JClass("String"), "alias"));
1293-
method.addParameter(new JParameter(new JClass("java.util.Set"), "parsed"));
1298+
method.addParameter(new JParameter(
1299+
new JCollectionType("java.util.Set", new JType("String"), hasJavaSourceSupport(5)), "parsed"));
12941300
method.addException(new JClass("XmlPullParserException"));
12951301

12961302
sc = method.getSourceCode();

0 commit comments

Comments
 (0)