change in behaviour of adjacent collapsed spans with inclusiveLeft/inclusiveRight

[jdleesmiller]

Example -- run this in the console on the CodeMirror home page:

editor.setValue('ab');
spanA = document.createElement('span'); spanA.innerText = 'A';
editor.markText({line: 0, ch: 0}, {line: 0, ch: 1}, {replacedWith: spanA, inclusiveRight: true});
spanB = document.createElement('span'); spanB.innerText = 'B';
editor.markText({line: 0, ch: 1}, {line: 0, ch: 2}, {replacedWith: spanB});

In 3.20, there's no error, and the result is "AB" (with two collapsed spans).

In 3.21 and later, there is an "Inserting collapsed marker partially overlapping an existing one" error in the second markText call.

If the inclusiveRight option is removed, then there's no error in 3.20 or 3.21 and later.

It turns out that we don't absolutely need to use the inclusiveLeft and inclusiveRight options in our application (the rich text mode on writeLaTeX), so we've worked around this by just removing them. But, for future reference, is the new behaviour the intended one?

[marijnh]

That was a bug. Attached patch should help.