Skip to content

mark all tokens as sensitive #266

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
matifali opened this issue Aug 13, 2024 · 0 comments
Open

mark all tokens as sensitive #266

matifali opened this issue Aug 13, 2024 · 0 comments

Comments

@matifali
Copy link
Member

matifali commented Aug 13, 2024

We should ensure that the following attributes are marked as sensitive.

I have seen an example in hcp-terraform-provider where they return data.hcp_vault_secrets_secret.example.secret_value as a sensitive value.

A related code snippet for this is:

https://github.com/hashicorp/terraform-provider-hcp/blob/d58d335805f6c67ecd26d547afdc10273aa96709/internal/provider/vaultsecrets/data_source_vault_secrets_secret.go#L54-L58

We are already doing it for

  1. data.coder_workspace_owner.me.ssh_private_key
  2. coder_agent.example.token

We should also do it for

  1. data.coder_workspace_owner.me.oidc_access_token
  2. data.coder_workspace_owner.me.session_token
  3. data.coder_external_auth.example.access_token
@coder-labeler coder-labeler bot added docs Improvements or additions to documentation enhancement labels Aug 13, 2024
@matifali matifali removed the docs Improvements or additions to documentation label Aug 13, 2024
@matifali matifali added this to the v2 milestone Aug 20, 2024
@matifali matifali removed this from the v2 milestone Dec 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant