Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Add Typescript 3.3 #668

Closed
SorenTheBrave opened this issue Dec 27, 2018 · 5 comments
Closed

Add Typescript 3.3 #668

SorenTheBrave opened this issue Dec 27, 2018 · 5 comments

Comments

@SorenTheBrave
Copy link

SorenTheBrave commented Dec 27, 2018

  • Name: Typescript
  • Version: 3.2
@zen0wu
Copy link

zen0wu commented Jan 29, 2019

Up this. I would suggest go all the way up to 3.2, since it's already there and totally (in my experience) backward compatible.

@kazk kazk changed the title Add Typescript 3.0 Add Typescript 3.2 Jan 29, 2019
@kazk kazk changed the title Add Typescript 3.2 Add Typescript 3.3 Feb 10, 2019
@kazk kazk self-assigned this Feb 10, 2019
@kazk kazk added the status/ready Ready to be deployed label Feb 10, 2019
@kazk kazk removed the status/ready Ready to be deployed label Feb 13, 2019
@kazk
Copy link
Member

kazk commented Feb 13, 2019

Added TypeScript 3.3. 368 kata wasn't compatible. Looks like most of the reference solution or helper function in tests has implicit any.

TypeScript 3.3 sets --target es2017 and --strict. I've decided to turn on --strict because it's the default when doing tsc --init and to disallow pasting JavaScript and calling it a translation.

@kazk kazk closed this as completed Feb 13, 2019
@kazk
Copy link
Member

kazk commented Feb 14, 2019

Here's a list of TypeScript kata that needs update. Most of them seems like they have implicit any somewhere on the author's side (reference solution, test helpers). Maybe they just copied JavaScript version.

Any help updating them will be appreciated.

@zen0wu
Copy link

zen0wu commented Feb 15, 2019

Thanks @kazk! Would be love to help. Since I've never done that, is there a tutorial where I can get started? Can I contribute to a kata that's somebody else? or hasn't solved myself?

@kazk
Copy link
Member

kazk commented Feb 15, 2019

@shivawu Thanks! See #690 (comment) for how to do it.

That example is for Rust, but it's the same work flow. It'll tell you what's wrong when you validate solution with the language version set to 3.3. I've fixed some and it was mostly just missing types.

I'd recommend solving them first because you won't be able to gain progress after editing kata.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants