Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not install imager.factor as a vocabulary #14

Closed
Kacarott opened this issue Jan 30, 2024 · 1 comment
Closed

Do not install imager.factor as a vocabulary #14

Kacarott opened this issue Jan 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Kacarott
Copy link
Collaborator

imager.factor is currently installed as a full vocabulary before being run during the docker build process, and is never removed. It is not required, or ever used after the build process, and so there is no reason for it to be installed as a vocabulary.

Instead, it should be run as a one-time script instead of being installed as a vocabulary. This will save some (trivial amount) of memory, simplify the build process, and prevent from polluting the vocabulary namespace.

@Kacarott Kacarott added the enhancement New feature or request label Jan 30, 2024
@nomennescio
Copy link
Collaborator

See #13

Polluting the vocabulary namespace is of no concern, as nameclashes will be caught before releases, but I consider those extremely unlikely.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants