Replies: 1 comment
-
Moved discussion to issue. |
Beta Was this translation helpful? Give feedback.
0 replies
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
-
Currently, both
it#{
anddescribe#{
leave a timestamp on the stack, used for reporting the runtime of the users code. This is essentially an implementation detail, but the issue is that it can interfere with user code. Consider this:This seems fairly regular code, however without the author realising it, it will be calling both
run-test
words with some arbitrary number, instead of the expected data structure!There is really no reason for the timestamps to be left on the stack like this, and it is simple to fix. Simply scan the relevant block, and run the resulting quotation inside
dip
such that the timestamp is moved to the retain stack. See this for a simple proof of concept.Beta Was this translation helpful? Give feedback.
All reactions