-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Preload some vocabs in extra
to improve runtimes
#47
Comments
NOTE: current Factor docs (for 0.100 development version on master branch) only list the following vocabs in extras:
Check which vocabs are supported by 0.98, and which are supported by 0.99. |
Factor 0.99 supports the following
|
Factor 0.98 supports the following
|
When looking at the original list as suggested in the issue, some of these are not |
extras
to improve runtimesextra
to improve runtimes
Note that the indicated load time increase to 5-6 seconds because of using libraries not preloaded, needs to be balanced against the size of the Factor image, plus the advantage some of these libraries add in terms of implementation effort. It still leaves a level playing field if a Kata depends on such a library. Most katas are not that time sensitive in the first place. Vocabs in |
Need to check if some of the mentioned vocabs have been moved to |
Out of the list of suggested vocabs, the following list is actually in
I don't think they can all be considered to be "commonly-used", although they might be useful to preload. |
Out of the list in the previous comment, the following vocabs are also present in 0.98:
So |
When I have referred to Also, all the vocab prefixes listed have vocabs in I have already done extensive testing with compile time, cold load time, warm load time, and image size. The final list is one which includes almost all vocabs which might be useful for kata, with only neglegible size difference (ie. the total size after increased image and removed extras ends up smaller than the current factor docker image). |
Thanks for investigating that. Right. If you have already tested that then I'm fine with it. I will make sure it will work for both 0.98 and 0.99. |
I will introduce specializations for versions 0.98 and 0.99, so it will be easy to maintain. |
Yes, but not only those. But the |
See codewars/factor#11
As a suggestion, for 0.99, consider preloading some vocabs as mentioned, but final list to be decided
The text was updated successfully, but these errors were encountered: