Merge pull request #25 from norzechowicz/naming

Deprecated PropertyMatcher and match function

Author: defrag

Diff for: composer.json

@@ -34,7 +34,7 @@
     },
     "extra": {
         "branch-alias": {
-            "dev-master": "1.1-dev"
+            "dev-master": "1.2-dev"
         }
     }
 }

Diff for: match.php

@@ -16,6 +16,9 @@
     );
 }
 
+/**
+ * @deprecated since 1.1, to be removed in 2.0. Use SimpleFactory and object approach instead
+ */
 if (!function_exists('match')) {
     /**
      * @param  mixed   $value

Diff for: src/Coduo/PHPMatcher/Matcher.php

@@ -1,19 +1,19 @@
 <?php
 namespace Coduo\PHPMatcher;
 
-use Coduo\PHPMatcher\Matcher\PropertyMatcher;
+use Coduo\PHPMatcher\Matcher\ValueMatcher;
 
 class Matcher
 {
     /**
-     * @var Matcher\PropertyMatcher
+     * @var ValueMatcher
      */
     private $matcher;
 
     /**
-     * @param PropertyMatcher $matcher
+     * @param ValueMatcher $matcher
      */
-    public function __construct(PropertyMatcher $matcher)
+    public function __construct(ValueMatcher $matcher)
     {
         $this->matcher = $matcher;
     }

Diff for: src/Coduo/PHPMatcher/Matcher/ArrayMatcher.php

@@ -20,9 +20,9 @@ class ArrayMatcher extends Matcher
     private $accessor;
 
     /**
-     * @param PropertyMatcher $propertyMatcher
+     * @param ValueMatcher $propertyMatcher
      */
-    public function __construct(PropertyMatcher $propertyMatcher)
+    public function __construct(ValueMatcher $propertyMatcher)
     {
         $this->propertyMatcher = $propertyMatcher;
     }

Diff for: src/Coduo/PHPMatcher/Matcher/ChainMatcher.php

@@ -7,22 +7,22 @@
 class ChainMatcher extends Matcher
 {
     /**
-     * @var array|PropertyMatcher[]
+     * @var array|ValueMatcher[]
      */
     private $matchers;
 
     /**
-     * @param array|PropertyMatcher[] $matchers
+     * @param array|ValueMatcher[] $matchers
      */
     public function __construct(array $matchers = array())
     {
         $this->matchers = $matchers;
     }
 
     /**
-     * @param PropertyMatcher $matcher
+     * @param ValueMatcher $matcher
      */
-    public function addMatcher(PropertyMatcher $matcher)
+    public function addMatcher(ValueMatcher $matcher)
     {
         $this->matchers[] = $matcher;
     }

Diff for: src/Coduo/PHPMatcher/Matcher/JsonMatcher.php

@@ -13,9 +13,9 @@ class JsonMatcher extends Matcher
     private $matcher;
 
     /**
-     * @param PropertyMatcher $matcher
+     * @param ValueMatcher $matcher
      */
-    public function __construct(PropertyMatcher $matcher)
+    public function __construct(ValueMatcher $matcher)
     {
         $this->matcher = $matcher;
     }

Diff for: src/Coduo/PHPMatcher/Matcher/Matcher.php

@@ -2,7 +2,7 @@
 
 namespace Coduo\PHPMatcher\Matcher;
 
-abstract class Matcher implements PropertyMatcher
+abstract class Matcher implements ValueMatcher
 {
     /**
      * @var string|null

Diff for: src/Coduo/PHPMatcher/Matcher/PropertyMatcher.php

@@ -2,29 +2,9 @@
 
 namespace Coduo\PHPMatcher\Matcher;
 
-interface PropertyMatcher
+/**
+ * @deprecated since 1.1, to be removed in 2.0. Use ValueMatcher instead
+ */
+interface PropertyMatcher extends ValueMatcher
 {
-    /**
-     * Matches value against the pattern
-     *
-     * @param $value
-     * @param $pattern
-     * @return boolean
-     */
-    public function match($value, $pattern);
-
-    /**
-     * Checks if matcher can match the pattern
-     *
-     * @param $pattern
-     * @return boolean
-     */
-    public function canMatch($pattern);
-
-    /**
-     * Returns a string description why matching failed
-     *
-     * @return null|string
-     */
-    public function getError();
 }

Diff for: src/Coduo/PHPMatcher/Matcher/ValueMatcher.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Coduo\PHPMatcher\Matcher;
+
+interface ValueMatcher
+{
+    /**
+     * Matches value against the pattern
+     *
+     * @param $value
+     * @param $pattern
+     * @return boolean
+     */
+    public function match($value, $pattern);
+
+    /**
+     * Checks if matcher can match the pattern
+     *
+     * @param $pattern
+     * @return boolean
+     */
+    public function canMatch($pattern);
+
+    /**
+     * Returns a string description why matching failed
+     *
+     * @return null|string
+     */
+    public function getError();
+}