Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug] Failed upload errors don't get caught, leaking out of build process #94

Closed
colbyfayock opened this issue Nov 10, 2023 · 1 comment · Fixed by #95
Closed

[Bug] Failed upload errors don't get caught, leaking out of build process #94

colbyfayock opened this issue Nov 10, 2023 · 1 comment · Fixed by #95
Labels
released

Comments

@colbyfayock
Copy link
Collaborator

colbyfayock commented Nov 10, 2023 •
edited
Loading

Bug Report

Describe the bug

introduced in #89

Is this a regression?

Steps To Reproduce the error

Expected behaviour

CodeSandbox or Live Example of Bug

Screenshot or Video Recording

Your environment

  • OS:
  • Node version:
  • Npm version:
  • Browser name and version:

Additional context
@colbyfayock colbyfayock mentioned this issue Nov 10, 2023
Merged
11 tasks
colbyfayock added a commit that referenced this issue Nov 10, 2023
@colbyfayock
fix: Fixes uncaught errors in concurrency loop (#95)
2c6a33b 
# Description

Concurrency was added for parallel uploads which introduced a bug where
the try/catch wrapping this didn't properly catch the errors being
thrown from within the async functions.

This moves the try/catch inside of each upload process

## Issue Ticket Number

<!-- Specifiy which issue this fixes by referencing the issue number
(`#11`) or issue URL. -->
<!-- Example: Fixes
#1 -->

Fixes #94 

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues)
ticket for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls)
for the same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Nov 10, 2023
@semantic-release-bot
chore(release): 1.13.1 [skip ci]
d72094b 
## [1.13.1](v1.13.0...v1.13.1) (2023-11-10)

### Bug Fixes

* Fixes uncaught errors in concurrency loop ([#95](#95)) ([2c6a33b](2c6a33b)), closes [#11](#11) [#94](#94)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes uncaught errors in concurrency loop cloudinary-community/netlify-plugin-cloudinary
1 participant
@colbyfayock