Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

If a project has a setup.cfg file, colcon ignores the setup.py file completely #65

Closed
rotu opened this issue Jun 28, 2019 · 1 comment · Fixed by #85
Closed

If a project has a setup.cfg file, colcon ignores the setup.py file completely #65

rotu opened this issue Jun 28, 2019 · 1 comment · Fixed by #85
Assignees
Labels
bug Something isn't working

Comments

@rotu
Copy link

rotu commented Jun 28, 2019

When creating a setup.py file, setup.cfg can be used to specify some data in a declarative manner. But the logic in RosPackageIdentification.identify ignores the setup.py file if a setup.cfg file is specified.

This came up in an ugly way for my project which defines data_files in setup.py but defines some other package data in the setup.cfg file. When colcon attempts to install the project with --symlink-install option, it completely omits the package data, since it only looks at the cfg file.

@rotu
Copy link
Author

rotu commented Oct 22, 2019

Thank you, @dirk-thomas!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
2 participants