Allow optional request headers #2

darronschall · 2023-02-12T15:03:52Z

This allows callers to add optional request headers on a per-call basis.

For example, to supply an HttpHeaders.IfNoneMatch value for ETag caching if the Twirp service supports it, like the twirp-rails gem does. Another optional use might be sending an Idempotency-Key header for idempotent requests.

Example usage of the generated code might look something like:

val eTagHeader = mapOf(HttpHeaders.IfNoneMatch to eTagValue)
val response = exampleService.getCacheableData(EmptyRequest(), eTagHeader)

This allows callers to add optional request headers on a per-call basis. For example, to supply an `HttpHeaders.IfNoneMatch` value for [ETag caching](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag) if the Twirp service supports it, like [the `twirp-rails` gem does](https://github.com/collectiveidea/twirp-rails#basic-caching-with-etagsif-none-match-headers). Another optional use might be sending an `Idempotency-Key` header for idempotent requests.

darronschall added 2 commits February 12, 2023 09:59

Cleanup: Remove unused param.

b40cc45

darronschall requested a review from danielmorrison February 12, 2023 15:03

darronschall enabled auto-merge February 12, 2023 17:18

danielmorrison approved these changes Feb 12, 2023

View reviewed changes

darronschall merged commit c85b803 into main Feb 12, 2023

darronschall deleted the allow-optional-request-headers branch February 13, 2023 03:29

darronschall mentioned this pull request Feb 15, 2023

Expose response headers in service result as a Pair #4

Merged

Provide feedback