add assembly tests for append rules

Author: rockjam

scalalib/test/resources/hello-world-multi/core/resources/reference.conf

@@ -0,0 +1,4 @@
+##############################
+# Core Reference Config File #
+##############################
+bar.baz=hello

scalalib/test/resources/hello-world-multi/core/src/Main.scala

@@ -0,0 +1,5 @@
+object Main extends App {
+  val person = Person.fromString("rockjam:25")
+  println(s"hello ${person.name}, your age is: ${person.age}")
+}
+

scalalib/test/resources/hello-world-multi/model/resources/reference.conf

@@ -0,0 +1,4 @@
+###############################
+# Model Reference Config File #
+###############################
+foo.bar=2

scalalib/test/resources/hello-world-multi/model/src/Person.scala

@@ -0,0 +1,8 @@
+object Person {
+  def fromString(s: String): Person = {
+    val Array(name, age) = s.split(":")
+    Person(name, age.toInt)
+  }
+}
+case class Person(name: String, age: Int)
+

scalalib/test/resources/hello-world/core/resources/reference.conf

@@ -0,0 +1,4 @@
+########################################
+# My application Reference Config File #
+########################################
+akka.http.client.user-agent-header="hello-world-client"

scalalib/test/src/mill/scalalib/HelloWorldTests.scala

@@ -3,15 +3,13 @@ package mill.scalalib
 import java.util.jar.JarFile
 
 import ammonite.ops._
-import ammonite.ops.ImplicitWd._
 import mill._
-import mill.define.{Discover, Target}
+import mill.define.Target
 import mill.eval.{Evaluator, Result}
 import mill.scalalib.publish._
 import mill.util.{TestEvaluator, TestUtil}
 import mill.scalalib.publish.VersionControl
 import utest._
-
 import utest.framework.TestPath
 
 import scala.collection.JavaConverters._
@@ -50,6 +48,23 @@ object HelloWorldTests extends TestSuite {
     }
   }
 
+  object HelloWorldAkkaHttp extends HelloBase {
+    object core extends HelloWorldModule{
+      def mainClass = Some("Main")
+      def ivyDeps = Agg(
+        ivy"com.typesafe.akka::akka-http:10.0.13"
+      )
+    }
+  }
+
+  object HelloWorldMulti extends HelloBase {
+    object core extends HelloWorldModule {
+      def mainClass = Some("Main")
+      def moduleDeps = Seq(model)
+    }
+    object model extends HelloWorldModule
+  }
+
   object HelloWorldWarnUnused extends HelloBase{
     object core extends HelloWorldModule {
       def scalacOptions = T(Seq("-Ywarn-unused"))
@@ -148,6 +163,15 @@ object HelloWorldTests extends TestSuite {
     attrs.get(Name.MAIN_CLASS).map(_.asInstanceOf[String])
   }
 
+  def jarEntries(jar: JarFile): Set[String] = {
+    jar.entries().asScala.map(_.getName).toSet
+  }
+
+  def readFileFromJar(jar: JarFile, name: String): String = {
+    val is = jar.getInputStream(jar.getEntry(name))
+    read(is)
+  }
+
   def compileClassfiles = Seq[RelPath](
     "Main.class",
     "Main$.class",
@@ -411,10 +435,11 @@ object HelloWorldTests extends TestSuite {
         val jarFile = new JarFile(result.path.toIO)
         val entries = jarFile.entries().asScala.map(_.getName).toSet
 
-        val manifestFiles = Seq[RelPath](
-          "META-INF" / "MANIFEST.MF"
+        val otherFiles = Seq[RelPath](
+          "META-INF" / "MANIFEST.MF",
+          "reference.conf"
         )
-        val expectedFiles = compileClassfiles ++ manifestFiles
+        val expectedFiles = compileClassfiles ++ otherFiles
 
         assert(
           entries.nonEmpty,
@@ -442,7 +467,7 @@ object HelloWorldTests extends TestSuite {
           evalCount > 0
         )
         val jarFile = new JarFile(result.path.toIO)
-        val entries = jarFile.entries().asScala.map(_.getName).toSet
+        val entries = jarEntries(jarFile)
 
         val mainPresent = entries.contains("Main.class")
         assert(mainPresent)
@@ -452,6 +477,52 @@ object HelloWorldTests extends TestSuite {
         assert(mainClass.contains("Main"))
       }
 
+      'assemblyRules - {
+        'appendWithDeps - workspaceTest(HelloWorldAkkaHttp) { eval =>
+          val Right((result, _)) = eval.apply(HelloWorldAkkaHttp.core.assembly)
+
+          val jarFile = new JarFile(result.path.toIO)
+
+          assert(jarEntries(jarFile).contains("reference.conf"))
+
+          val referenceContent = readFileFromJar(jarFile, "reference.conf")
+
+          assert(
+            // akka modules configs are present
+            referenceContent.contains("akka-http Reference Config File"),
+            referenceContent.contains("Akka Actor Reference Config File"),
+            referenceContent.contains("Akka Stream Reference Config File"),
+            // our application config is present too
+            referenceContent.contains("My application Reference Config File"),
+            referenceContent.contains(
+              """akka.http.client.user-agent-header="hello-world-client""""
+            )
+          )
+        }
+        'appendMultiModule - workspaceTest(
+          HelloWorldMulti,
+          resourcePath = pwd / 'scalalib / 'test / 'resources / "hello-world-multi"
+        ) { eval =>
+          val Right((result, _)) = eval.apply(HelloWorldMulti.core.assembly)
+
+          val jarFile = new JarFile(result.path.toIO)
+
+          assert(jarEntries(jarFile).contains("reference.conf"))
+
+          val referenceContent = readFileFromJar(jarFile, "reference.conf")
+
+          assert(
+            // reference config from core module
+            referenceContent.contains("Core Reference Config File"),
+            // reference config from model module
+            referenceContent.contains("Model Reference Config File"),
+            // concatenated content
+            referenceContent.contains("bar.baz=hello"),
+            referenceContent.contains("foo.bar=2")
+          )
+        }
+      }
+
       'run - workspaceTest(HelloWorldWithMain){eval =>
         val Right((result, evalCount)) = eval.apply(HelloWorldWithMain.core.assembly)