Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make interp part of the Module #265

Closed
shengc opened this issue Mar 29, 2018 · 4 comments
Closed

make interp part of the Module #265

shengc opened this issue Mar 29, 2018 · 4 comments
Milestone

Comments

@shengc
Copy link
Contributor

shengc commented Mar 29, 2018

Or at least, make interp.repositories() the default choice of Module.repositories and Module.scalaWorker.repositories unless it is empty. This way if somebody wants to globally reset repositories, he/she can specify the custom set in predef.sc.

@lihaoyi
Copy link
Member

lihaoyi commented Apr 4, 2018

This seems reasonable

@lihaoyi
Copy link
Member

lihaoyi commented Apr 4, 2018

Getting it the default choice for Module.scalaWorker.repositories might be hard though; the default scalaWorker gets defined globally, while interp is scoped to a particular build run.

@shengc
Copy link
Contributor Author

shengc commented Apr 5, 2018

is it possible to build in a macro to rewrite build.sc that overrides the scalaWorker with interp.repositories ?

@lihaoyi
Copy link
Member

lihaoyi commented Apr 23, 2023

repositories has been part of CoursierModule for some time now, and #2377 makes this moot since there's no more interp (except interp.watchValue for backwards compat)

@lihaoyi lihaoyi closed this as completed Apr 23, 2023
@lefou lefou added this to the 0.11.0-M8 milestone Apr 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants