fix(JsonObject): fix error message for unknown method

commercetools · Oct 21, 2015 · 22431f8 · 22431f8
1 parent d2c01d5
commit 22431f8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/Error/Message.php b/src/Error/Message.php
@@ -25,7 +25,7 @@ class Message
 
     const AUTHENTICATION_FAIL = 'Authentication failed: %s';
 
-    const UNKNOWN_METHOD = 'Unknown method: %s (unknown field: %s)';
+    const UNKNOWN_METHOD = 'Unknown method: %s';
     const UNKNOWN_FIELD = 'Unknown field: "%s" - called: %s(%s)';
     const WRONG_TYPE = 'Wrong type for field "%s". Expected %s.';
     const EXPECTS_PARAMETER = 'Excepts parameter "%s" to be %s, null given.';

diff --git a/src/Model/Common/JsonObject.php b/src/Model/Common/JsonObject.php
@@ -51,9 +51,13 @@ public function __call($method, $arguments)
         $field = lcfirst(substr($method, 3));
 
         if (!$this->hasField($field)) {
-            throw new \BadMethodCallException(
-                sprintf(Message::UNKNOWN_FIELD, $field, $method, implode(', ', $arguments))
-            );
+            if ($action == 'get' || $action == 'set') {
+                throw new \BadMethodCallException(
+                    sprintf(Message::UNKNOWN_FIELD, $field, $method, implode(', ', $arguments))
+                );
+            } else {
+                throw new \BadMethodCallException(sprintf(Message::UNKNOWN_METHOD, $method, $field));
+            }
         }
         switch ($action) {
             case 'get':