Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nearby upload not being linked from Wikidata #6123

Open
nicolas-raoul opened this issue Jan 13, 2025 · 7 comments · May be fixed by #6156
Open

Nearby upload not being linked from Wikidata #6123

nicolas-raoul opened this issue Jan 13, 2025 · 7 comments · May be fixed by #6156

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Jan 13, 2025

Reproducible every time.

Steps to reproduce:

  1. Use prod flavor
  2. Go to Nearby
  3. Tap a red pin
  4. Upload a picture for it

Expectation: Wikidata item page now shows that picture.

Actually: Wikidata item page still has no picture. Error "Failed to update corresponding Wikidata entity!" appears.

Also, they are not marked as uploaded, and it seems like the upload fails at first.

Screenshot_20250113-134318.png

@Sujal-Gupta-SG
Copy link
Contributor

Hey @nicolas-raoul ,
let me try to solve this issue. Can you assign this issue to me?

@Sujal-Gupta-SG
Copy link
Contributor

Hii @nicolas-raoul !
I'm having some issue like i have to show all contribution images which having same latitude or longitude according to pin(particular place) or does i have to show the latest uploaded image of that particular place ,In other words when someone click on the pin does in botton every image related to that latitude will be shown or the latest image will be shown

@nicolas-raoul
Copy link
Member Author

Are you able to reproduce the failure? If yes, just try to make it not fail. 🙂

@Sujal-Gupta-SG
Copy link
Contributor

there is a crash while uploading from nearby firstly i'm checking on it why it causing

@nicolas-raoul
Copy link
Member Author

The crash is a separate issue: #6137 right?

To investigate the present issue, you can use the custom picker. :-)

@nicolas-raoul
Copy link
Member Author

Somehow the caption also seems to not be set correctly on Nearby uploads, and the description is a bit malformed it seems.

@nicolas-raoul
Copy link
Member Author

  1. I just built the app from commit 3e020ed (October 24, 2024), and I get the same Failed to update corresponding Wikidata entity!.
  2. I remember I successfully uploaded a picture from Nearby on 12 January 2025 with recent (at that time) in-PR commit 045cfa2: https://www.wikidata.org/wiki/Q111445947

... so this may be due to a server-side change, rather than a change in our app.

However, I can see that there is no slowdown in the pace of Wikidata edits being made by Nearby: https://www.wikidata.org/w/index.php?hidebots=1&translations=filter&hidecategorization=1&tagfilter=wikimedia-commons-app&limit=500&days=30&enhanced=1&hideWikibase=1&title=Special:RecentChanges&urlversion=2 which seems to indicate that at least the currently released version of the app is immune to the problem. Unfortunately due to Gradle/Java changes that old code is now pretty difficult to build.

# for free to join this conversation on GitHub. Already have an account? # to comment