Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] User doesn't show in the contibutions page #6198

Open
parneet-guraya opened this issue Feb 20, 2025 · 2 comments · May be fixed by #6209
Open

[Bug] User doesn't show in the contibutions page #6198

parneet-guraya opened this issue Feb 20, 2025 · 2 comments · May be fixed by #6209

Comments

@parneet-guraya
Copy link
Contributor

parneet-guraya commented Feb 20, 2025

User text field is empty whenever uploaded from web client with these options

Choosing someone else is the creator

Image

Below, doesn't matter if you enter author name or not.

Then, from the app you can see the contribution is shown but user field is empty.

Image

Would you like to work on this?

Yes

@parneet-guraya parneet-guraya changed the title User doesn't show in the contibutions page [Bug] User doesn't show in the contibutions page Feb 20, 2025
@parneet-guraya
Copy link
Contributor Author

The reason is we're reading from author field when loading the data not username field and author is returned empty whenever we choose this work is created by someone else on web client.

Also, if however I upload from mobile app then we default to using the username. This is confusing so which one should be shown? username the one who uploaded or author the one who is the creator of the image?

Since, author is returned empty in this scenario, whatever piece of code uses it leads to bugs

  • This PR introduced the change to use author and now this bug occurs.
  • This Bug also occurs because we use author when trying to nominate for deletion.

@nicolas-raoul , what do you think?

@nicolas-raoul
Copy link
Member

Based on what you wrote, I think our app should set both username and author.

We should not allow our users to upload other people's pictures, because 99% would be copyright violations.

Also, the app should show username when author is nnt present.

Does that sound sensible?

@parneet-guraya parneet-guraya linked a pull request Feb 24, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants