Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Upload: Can't cancel or go back from language selection popup #6215

Open
nicolas-raoul opened this issue Feb 25, 2025 · 2 comments · May be fixed by #6216
Open

Upload: Can't cancel or go back from language selection popup #6215

nicolas-raoul opened this issue Feb 25, 2025 · 2 comments · May be fixed by #6216
Assignees
@parneet-guraya
Labels
bug

Comments

@nicolas-raoul
Copy link
Member

I thought that issue had been solved recently, maybe the fix was lost due to refactoring?

screen-20250225-120337.mp4
@parneet-guraya
Copy link
Contributor

Strange! it was indeed working before.

#6078 (comment)

@parneet-guraya
Copy link
Contributor

parneet-guraya commented Feb 25, 2025 •
edited
Loading

I converted the file myself and diffed with current one. You're right, for some reason it does remove the cancel button click listener during conversion.

Image

Let me fix that!

@parneet-guraya parneet-guraya linked a pull request Feb 25, 2025 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@parneet-guraya parneet-guraya

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cancel button in the language dialog parneet-guraya/apps-android-commons
2 participants
@nicolas-raoul @parneet-guraya