Apply review suggestions

Author: Gnimuc

include/clang/Interpreter/CppInterOp.h

@@ -77,7 +77,6 @@ namespace Cpp {
   /// function, constructor or destructor.
   class JitCall {
   public:
-    friend CPPINTEROP_API JitCall MakeFunctionCallable(TCppConstFunction_t);
     friend CPPINTEROP_API JitCall
     MakeFunctionCallable(TInterp_t I, TCppConstFunction_t func);
     enum Kind : char {

lib/Interpreter/CppInterOp.cpp

@@ -857,7 +857,7 @@ namespace Cpp {
 
   TCppIndex_t GetFunctionRequiredArgs(TCppConstFunction_t func)
   {
-    auto *D = (const clang::Decl *) func;
+    const auto* D = static_cast<const clang::Decl*>(func);
     if (auto* FD = llvm::dyn_cast_or_null<FunctionDecl>(D))
       return FD->getMinRequiredArguments();
 
@@ -923,7 +923,8 @@ namespace Cpp {
   }
 
   bool IsFunctionDeleted(TCppConstFunction_t function) {
-    auto *FD = cast<const FunctionDecl>((const clang::Decl*)function);
+    const auto* FD =
+        cast<const FunctionDecl>(static_cast<const clang::Decl*>(function));
     return FD->isDeleted();
   }
 
@@ -1054,7 +1055,8 @@ namespace Cpp {
 
   bool IsMethod(TCppConstFunction_t method)
   {
-    return dyn_cast_or_null<CXXMethodDecl>((const clang::Decl*)method);
+    return dyn_cast_or_null<CXXMethodDecl>(
+        static_cast<const clang::Decl*>(method));
   }
 
   bool IsPublicMethod(TCppFunction_t method)
@@ -1073,18 +1075,18 @@ namespace Cpp {
 
   bool IsConstructor(TCppConstFunction_t method)
   {
-    auto *D = (const Decl *) method;
+    const auto* D = static_cast<const Decl*>(method);
     return llvm::isa_and_nonnull<CXXConstructorDecl>(D);
   }
 
   bool IsDestructor(TCppConstFunction_t method)
   {
-    auto *D = (const Decl *) method;
+    const auto* D = static_cast<const Decl*>(method);
     return llvm::isa_and_nonnull<CXXDestructorDecl>(D);
   }
 
   bool IsStaticMethod(TCppConstFunction_t method) {
-    const auto* D = (const Decl*)method;
+    const auto* D = static_cast<const Decl*>(method);
     if (auto *CXXMD = llvm::dyn_cast_or_null<CXXMethodDecl>(D)) {
       return CXXMD->isStatic();
     }
@@ -1456,10 +1458,6 @@ namespace Cpp {
     }
   }
 
-  QualType GetBuiltinType(const std::string& name, Sema& sema) {
-    return findBuiltinType(name, sema.getASTContext());
-  }
-
   TCppType_t GetType(const std::string &name) {
     QualType builtin = findBuiltinType(name, getASTContext());
     if (!builtin.isNull())
@@ -2583,7 +2581,7 @@ namespace Cpp {
 
     CPPINTEROP_API JitCall MakeFunctionCallable(TInterp_t I,
                                                 TCppConstFunction_t func) {
-      auto* D = (const clang::Decl*)func;
+      const auto* D = static_cast<const clang::Decl*>(func);
       if (!D)
         return {};