Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Opus header gain modes cause a crash on Windows #122

Closed
ThrowElse opened this issue Jul 24, 2024 · 2 comments
Closed

Opus header gain modes cause a crash on Windows #122

ThrowElse opened this issue Jul 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ThrowElse
Copy link

Using the header gain modes result in a crash without error messages. Previous values are cleared but no new values are written.

Tested with v3.5.1 on freshly installed and also fully updated installations of Windows 7, 10 and 11

@complexlogic
Copy link
Owner

I confirm this on my end and will investigate a solution.

@complexlogic complexlogic added the bug Something isn't working label Jul 27, 2024
@complexlogic
Copy link
Owner

complexlogic commented Jul 27, 2024

The root cause of this bug was a resource sharing issue. The input file is already open with the TagLib File object, and then the header gain write function tries to open it. It seems that the Windows OS file protocol has a problem with this, but Unix file systems don't. Sometimes system-related behavior can be inconsistent across platforms.

In this case, the solution is relatively straightforward. I changed the code to close the TagLib File object before writing to the header gain. This prevents the resource conflict, so now everything works fine across all supported platforms.

You can use the development build with the fix incorporated until the next release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants