Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] --extras-require-all option doesn't work with pyproject.toml-based projects #506

Open
jplumail opened this issue Oct 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jplumail
Copy link

Describe the bug
For projects with extra dependencies defined in the pyproject.toml file, grayskull's --extras-require-all option doesn't work.

To Reproduce

$ grayskull pypi --extras-require-all dask=2023.10.0

Expected behavior
I expected the array and dataframe extras to be included. With packages like numpy or pandas.

Outputs

{% set name = "dask" %}
{% set version = "2023.10.0" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/dask-{{ version }}.tar.gz
  sha256: 3fdfdbdb5f9f3a556487bf37142e5a730dab2f2c8eca0b6c79d11199c30220e3

build:
  entry_points:
    - dask = dask.__main__:main
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
  number: 0

requirements:
  host:
    - python >=3.9
    - setuptools >=62.6
    - versioneer ==0.28
    - pip
  run:
    - python >=3.9
    - click >=8.0
    - cloudpickle >=1.5.0
    - fsspec >=2021.09.0
    - packaging >=20.0
    - partd >=1.2.0
    - pyyaml >=5.3.1
    - toolz >=0.10.0
    - importlib-metadata >=4.13.0  # 
# Extra: testing
    - pandas
    - pytest
    - pytest-cov
    - pytest-rerunfailures
    - pytest-timeout
    - pytest-xdist
    - pre-commit

test:
  imports:
    - dask
  commands:
    - pip check
    - dask --help
  requires:
    - pip

about:
  summary: Parallel PyData with Task Scheduling
  license: BSD-3-Clause
  license_file: LICENSE.txt

Environment:

$ grayskull --version
2.5.1

Additional context
The dask example worked until the 2023.4.0 version, when they switched from setup.py/setup.cfg to pyproject.toml (see this commit).

@jplumail jplumail added the bug Something isn't working label Oct 27, 2023
@bjudkewitz
Copy link

+1 this seems like a big problem to me and keeps us from using grayskull. it would be great if this could be fixed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants