Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

avoid_selector isn't working #566

Open
maresb opened this issue Sep 29, 2024 · 1 comment
Open

avoid_selector isn't working #566

maresb opened this issue Sep 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@maresb
Copy link
Contributor

maresb commented Sep 29, 2024

Describe the bug

There's a great feature by @BastianZim to avoid superfluous selectors in certain cases and encourage noarch.

Unfortunately I just discovered that it requires the --strict-conda-forge flag to enable. Could this be better documented? Or even better could we enable --strict-conda-forge by default?

Also I notice here that the option is not being found because the names are not normalized. In particular, looking with a debugger, I see pkg = 'importlib-metadata >=3.6.0 # [py<310]', so we query info_pkgs on the key importlib-metadata, but info_pkgs only contains importlib_metadata. I don't know where is the proper place to enact the normalization of keys since I don't understand the schema of config.yaml. (This would also be nice to document! For example, why is it called import_name and not pypi_name?)

To Reproduce

grayskull pypi --strict-conda-forge mdformat

Expected behavior
A noarch recipe

Outputs

...
- importlib-metadata >=3.6.0  # [py<310]
...

Environment:
dev environment on main

@maresb maresb added the bug Something isn't working label Sep 29, 2024
@marcelotrevisani
Copy link
Member

there was some discussions to make it the default
I prefer it to be the default behaviour and put a flag to disable it

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants