Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE]: when a workflow is removed, not all of its children are removed. #272

Open
mspasiano opened this issue Sep 30, 2024 · 3 comments

Comments

@mspasiano
Copy link

Please read our contributor guide before creating an issue.
Also consider discussing your idea on the discussion forum first.

Describe the Feature Request

When a workflow is removed, not all of its children are removed.

Describe Preferred Solution

You could include in the removal of a workflow the search for children via parent_workflow_id to then be able to remove them together with the connected tasks.

@v1r3n
Copy link
Collaborator

v1r3n commented Oct 5, 2024

Hi @mspasiano can you provide a sample workflow and steps to reproduce?

@mspasiano
Copy link
Author

For example, at this point you could search for all workflows that have the incoming workflowId as parent_workflow_id and delete them by calling the same method

@mspasiano
Copy link
Author

mspasiano commented Oct 8, 2024

Inspecting the code a bit, the solution could be to store the parent_workflow_id information on the indexes and in case these are active use it to get all the child workflows.
Could this be a viable solution?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants