Gif replace #519
Merged
Gif replace #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying configcat-docs with
|
| Latest commit: |
38248ff
|
| Status: | ⚡️ Build in progress... |
|
Head's up @configcat/ux-qa-team - someone needs a UX review! |
Deploying configcat-docs with
|
| Latest commit: |
38248ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc4a56a4.docs-xmy.pages.dev |
| Branch Preview URL: | https://repalce-gifs.docs-xmy.pages.dev |
|
From a UX point of view, it all looks good. 👍 One thing I noticed is that in the VS Code guide, the top of some of the images is cropped, which doesn't look very nice:
However, this issue existed in the original gifs, so it's ok with me if we deal with this later, not in the current PR. |
|
I created a ticket for the VSCode docs update so we won't forget. |
laliconfigcat
approved these changes
Feb 26, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Jira, monday.com, VSCode, Trello and IntelliJ v2 docs gifs are replaced with mp4. In the case of IntelliJ, the V1 doc is the same, so I replaced the gifs there as well.
Trello card
link to the Trello card
Notes for QA
The Jira, monday.com, VSCode, Trello and IntelliJ v2 docs gifs are replaced with mp4. In the case of IntelliJ, the V1 doc is the same, so I replaced the gifs there as well.
Requirement checklist