Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

multi lines? #2

Open
MoustafaElhadary opened this issue Feb 4, 2020 · 3 comments
Open

multi lines? #2

MoustafaElhadary opened this issue Feb 4, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@MoustafaElhadary
Copy link

MoustafaElhadary commented Feb 4, 2020

image

I am trying to achieve a look similar to that . What would be the best way to do it within this package?

Btw I love the package! it's really well documented and has been super easy to use!

@nhannah
Copy link
Contributor

nhannah commented Feb 5, 2020

@MoustafaElhadary there is only support for a single line at the moment, but it is something I can look into. I think the desired design would be the key question. Would you just like a second line to be shown or would you want a second tool tip & cursor as well? Or would you like the same tool tip to receive the y-position for both lines? Showing only one at a time (tool tips) would be doable but I think the result would be an inconsistent experience depending on the how close the data sets are.

@nhannah nhannah added the enhancement New feature or request label Feb 5, 2020
@MoustafaElhadary
Copy link
Author

@nhannah Thank you so much for your quick response! I think adding a tooltip per line would be ideal!
I definitely agree with you that it might be a possible issue. Maybe show an average with ~before the data point?
There has to be a better way for sure!

@nhannah
Copy link
Contributor

nhannah commented Feb 6, 2020

@MoustafaElhadary I will look into it, I don't think it will be an issue to show them both at once, or create a single one such as this, I only would see the issue in trying to display them at two different x-coordinates simultaneously or poping between which is shown by which your finger is closer to as there would definitely be an edge case where which one is shown starts jumping.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants