Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI: lint is failing #351

Closed
AkihiroSuda opened this issue Nov 18, 2024 · 2 comments
Closed

CI: lint is failing #351

AkihiroSuda opened this issue Nov 18, 2024 · 2 comments

Comments

@AkihiroSuda
Copy link
Member

https://github.com/containerd/cgroups/actions/runs/11691328166/job/32558246281

Error: src/github.com/containerd/cgroups/cgroup1/cgroup.go:37:32: undefined: specs (typecheck)
  func New(path Path, resources *specs.LinuxResources, opts ...InitOpts) (Cgroup, error) {
                                 ^
  Error: src/github.com/containerd/cgroups/cgroup1/cgroup.go:132:46: undefined: specs (typecheck)
  func (c *cgroup) New(name string, resources *specs.LinuxResources) (Cgroup, error) {
                                               ^
  Error: src/github.com/containerd/cgroups/cgroup1/cgroup.go:353:36: undefined: specs (typecheck)
  func (c *cgroup) Update(resources *specs.LinuxResources) error {
                                     ^
  Error: src/github.com/containerd/cgroups/cgroup1/systemd.go:150:10: undefined: dbus (typecheck)
  		Value: dbus.MakeVariant(units),
  		       ^
  Error: src/github.com/containerd/cgroups/cgroup1/utils.go:200:15: undefined: cgroups (typecheck)
  	x, _, err := cgroups.ParseCgroupFileUnified(path)
  	             ^
  Error: src/github.com/containerd/cgroups/cgroup1/utils.go:209:9: undefined: cgroups (typecheck)
  	return cgroups.ParseCgroupFileUnified(path)
  	       ^
  Error: src/github.com/containerd/cgroups/cgroup1/paths_test.go:108:25: undefined: cgroups (typecheck)
  	paths, unified, err := cgroups.ParseCgroupFromReaderUnified(r)
  	                       ^
  Error: src/github.com/containerd/cgroups/cgroup2/manager.go:1009:10: undefined: dbus (typecheck)
  		Value: dbus.MakeVariant(units),
  		       ^
  Error: src/github.com/containerd/cgroups/cgroup2/utils.go:384:28: undefined: dbus (typecheck)
  		if dbusError, ok := err.(dbus.Error); ok {
[...]
@AlbertoBarba
Copy link
Contributor

@AkihiroSuda i wasn't able to reproduce the linter output. However i've found out that the lint jobs where using the wrong go version due to a typo. On the PR the lint jobs are currently green

@AkihiroSuda
Copy link
Member Author

Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants