Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ttrpc golang stream request with no FLAG_NO_DATA set #221

Open
abel-von opened this issue Mar 14, 2024 · 1 comment · May be fixed by #229
Open

ttrpc golang stream request with no FLAG_NO_DATA set #221

abel-von opened this issue Mar 14, 2024 · 1 comment · May be fixed by #229

Comments

@abel-von
Copy link
Contributor

The empty request is determined by whether FLAG_NO_DATA is set after #208 , but golang ttrpc seems not set this flag even it is an empty request. https://github.com/containerd/ttrpc/blob/main/client.go#L495. Shall we make it compatible with the case that client is golang? or do we set the flag in golang ttrpc?

@wllenyj
Copy link
Collaborator

wllenyj commented Mar 21, 2024

We should be compatible with containerd/ttrpc#157. Or there is a good enough reason to add it in golang.

@abel-von abel-von linked a pull request May 13, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants