Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Performance issues on fetch all OTP deployments #574

Closed
landonreed opened this issue May 7, 2020 · 1 comment · Fixed by #575
Closed

Performance issues on fetch all OTP deployments #574

landonreed opened this issue May 7, 2020 · 1 comment · Fixed by #575
Labels
bug released

Comments

@landonreed
Copy link
Contributor

landonreed commented May 7, 2020 •
edited
Loading

When fetching the 511NY list of deployments with the latest dev branch of datatools-server. The response can take up to (!!!!!) one minute. After some debugging, this looks to be attributed to AWS calls for ec2 instances assigned to each deployment/server. These calls are happening for the JSON properties #project as well as #ec2Instances.
@landonreed landonreed added the bug label May 7, 2020
landonreed added a commit to ibi-group/datatools-server that referenced this issue May 7, 2020
@landonreed
fix(perf): remove Deployment#project JSON property
507d6ac 
re ibi-group/datatools-ui#574
landonreed added a commit to ibi-group/datatools-server that referenced this issue May 7, 2020
@landonreed
perf(Deployment): remove ec2Instances field from getAllDeployments call
f2c5da0 
re ibi-group/datatools-ui#574
landonreed added a commit that referenced this issue May 7, 2020
@landonreed
fix(Deployment): refactor Deployment fields to fix perf issues
9b66f89 
This corresponds to changes in ibi-group/datatools-server#310

fix #574
@landonreed landonreed mentioned this issue May 7, 2020
Merged
5 tasks
@landonreed
Copy link
Contributor Author

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Deployment fields to fix perf issues ibi-group/datatools-ui
1 participant
@landonreed