-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Fixes #4957 - Updated yaml health check to port 8080 as per Penpot 2.4.* changes #5047
fix: Fixes #4957 - Updated yaml health check to port 8080 as per Penpot 2.4.* changes #5047
Conversation
v4.0.0-beta.390
…s per Penpot 2.4.* changes
My first public pull request - apologies if I have done it wrong, I tried following your steps as closely as possible |
hmm jut tried this fix, and my container for penpot is still not showing healthy, it fails on the deployment. I am on version 390 and installed penpot from the available images |
It does take a few minutes for the frontend to show as healthy. Is the penpot frontend ui accessible to you? |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I felt like this might not be the only change needed to get this template back to work. For example, something like what's mentioned here should be done (i.e. let Coolify proxy know it shall work on 8080 not 80). I played with it for an hour today but still not able to get a fresh installation to work. Would love some more expertise here. |
Hey @ycsh-w thank's for pointing that out. I think my testing wasn't valid as I was using the one-click deployment and then change the yaml file. But you were correct, try this out:
I also extended the backend health check as it takes a while for the migrations to load for the first time running it. Depending on your server if it fails the first time, just check the backend logs to ensure migrations have completed and then restart it again. |
…lth check on backend due to migrations timing it out previously
Seems to be working, Thanks for the PR. |
Changes
Issues