Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unnecessary assumption in sorted_take #40

Open
ybertot opened this issue Jun 12, 2021 · 5 comments
Open

Unnecessary assumption in sorted_take #40

ybertot opened this issue Jun 12, 2021 · 5 comments

Comments

@ybertot
Copy link

ybertot commented Jun 12, 2021

Hello,
in CoqEAL0.1, sorted_take (from ssrcomplements.v) had no transitivity assumption. In CoqEAL1.0.5, such an assumption exists. It may turn out be a problem one day.

@proux01
Copy link
Collaborator

proux01 commented Jun 12, 2021

Indeed, this lemma should be removed as it is now in MC https://github.com/math-comp/math-comp/blob/14097e37cb3b0590ef5d91809acf4fed0fb22f1a/mathcomp/ssreflect/path.v#L369

@ybertot
Copy link
Author

ybertot commented Jun 14, 2021

I do not understand. sorted_take does not occur in the current master branch of math-comp. What is the commit that @proux01 mentions attached to?

@proux01
Copy link
Collaborator

proux01 commented Jun 14, 2021

@ybertot
Copy link
Author

ybertot commented Jun 14, 2021

thks, I did not pay enough attention.

@ybertot ybertot closed this as completed Jun 14, 2021
@proux01
Copy link
Collaborator

proux01 commented Jun 14, 2021

I'd rather keep this open to remember to do the change once MC 1.13 is out.

@proux01 proux01 reopened this Jun 14, 2021
@proux01 proux01 mentioned this issue Jun 16, 2021
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants