Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

etcdserver, api, membership: don't race on setting version #6045

Merged
merged 1 commit into from
Jul 27, 2016
Merged

etcdserver, api, membership: don't race on setting version #6045

merged 1 commit into from
Jul 27, 2016

Conversation

heyitsanthony
Copy link
Contributor

@hongchaodeng
Copy link
Contributor

With this fix, what's the output if we have v2 enabled? What if v3 enabled? How long does it take in between?

@heyitsanthony
Copy link
Contributor Author

@hongchaodeng v2 will be not_decided or some 2.x in etcdcluster; basic v2 functionality should work regardless if you can fetch the version. If curl gives etcdcluster as >3.0.0, there shouldn't be any capability errors when using v3 api; this PR gets rid of that 500ms delay that we were discussing the other day.

@hongchaodeng
Copy link
Contributor

Sounds good.
LGTM after test passed.

@xiang90
Copy link
Contributor

xiang90 commented Jul 26, 2016

lgtm

@heyitsanthony heyitsanthony force-pushed the fix-version-race branch 2 times, most recently from 1842c02 to de2c3ec Compare July 27, 2016 01:19
@heyitsanthony heyitsanthony merged commit 13c2d32 into etcd-io:master Jul 27, 2016
@heyitsanthony heyitsanthony deleted the fix-version-race branch July 27, 2016 15:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heyitsanthony @hongchaodeng @xiang90 @gyuho