mvcc: Add metric for count of db key revisions compacted. #8280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heyitsanthony Here's one of the metrics that might help us in the future. |
|
would s/Revisions/Keys be better? There may be confusion between an etcd revision (mainrev) and a backend revision (mainrev + subrev). |
Codecov Report
@@ Coverage Diff @@
## master #8280 +/- ##
==========================================
- Coverage 76.42% 76.23% -0.19%
==========================================
Files 346 346
Lines 27055 27059 +4
==========================================
- Hits 20676 20628 -48
- Misses 4901 4940 +39
- Partials 1478 1491 +13
Continue to review full report at Codecov.
|
|
@heyitsanthony s/Revisions/Keys sounds good. I'll update the PR. |
jpbetz
force-pushed
the
compaction-metrics
branch
from
2d2c076 to
6cf2863
Compare
When digging into etcd/boltdb "storage space exceeded" issues, this metric may help answer questions about if/when compactions occured and how much data was freed.
jpbetz
force-pushed
the
compaction-metrics
branch
from
6cf2863 to
c06953a
Compare
|
lgtm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When digging into etcd/boltdb "storage space exceeded" issues, this metric may help answer questions about if/when compactions occured and how much data was freed.