Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

*: upgrade to grpclog.LoggerV2 #8533

Merged
merged 3 commits into from
Sep 12, 2017
Merged

*: upgrade to grpclog.LoggerV2 #8533

merged 3 commits into from
Sep 12, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 8, 2017

grpclog.Logger has been deprecated.

@gyuho gyuho added the WIP label Sep 8, 2017
grpclog.Logger has been deprecated.
grpclog.Logger has been deprecated.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@gyuho gyuho merged commit 9553afb into etcd-io:master Sep 12, 2017
@gyuho gyuho deleted the grpc branch September 12, 2017 10:53
@gyuho gyuho changed the title *: upgrade grpclog to LoggerV2 *: upgrade to grpclog.LoggerV2 Nov 21, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@80aa810). Click here to learn what that means.
The diff coverage is 85.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8533   +/-   ##
=========================================
  Coverage          ?   76.21%           
=========================================
  Files             ?      359           
  Lines             ?    29740           
  Branches          ?        0           
=========================================
  Hits              ?    22667           
  Misses            ?     5501           
  Partials          ?     1572
Impacted Files Coverage Δ
clientv3/watch.go 96.28% <0%> (ø)
auth/simple_token.go 93.51% <100%> (ø)
clientv3/auth.go 95.65% <100%> (ø)
clientv3/ordering/kv.go 85.29% <100%> (ø)
clientv3/concurrency/election.go 81.88% <100%> (ø)
clientv3/ready_wait.go 100% <100%> (ø)
client/keys.go 91.45% <100%> (ø)
client/client.go 84.64% <100%> (ø)
clientv3/kv.go 96.77% <100%> (ø)
clientv3/txn.go 100% <100%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80aa810...3b3d392. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants