Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(rendering): fix image overflow issues by restoring data type check, and fix window level to be maintained if it was modified by the user and image data can't be reused #1829

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

IbrahimCSAE
Copy link
Collaborator

Context

Some MR images were overflowing and not rendering correctly because we were no longer checking the data type, this has been restored. A fix for the window level has been added to also maintain it if the image data can't be re-used

@IbrahimCSAE IbrahimCSAE requested a review from sedghi February 16, 2025 00:13
Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 6724f1b
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67b12d9b203cef00088c838c
😎 Deploy Preview https://deploy-preview-1829--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE changed the title fix(rendering): fix image overflow issues by restoring data type check, and fix window level to be maintain if it was modified by the user and image data can't be reused fix(rendering): fix image overflow issues by restoring data type check, and fix window level to be maintained if it was modified by the user and image data can't be reused Feb 16, 2025
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi merged commit f5ff886 into main Feb 18, 2025
22 checks passed
@sedghi sedghi deleted the fix/overflow-issue branch February 18, 2025 14:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants