Minor refactor

wilguo · wilguo · commit 8b55f9034872 · 2025-04-10T15:50:14.000-07:00
Signed-off-by: Wilbert Guo &lt;wilbeguo@amazon.com&gt;
diff --git a/pkg/ruler/ruler.go b/pkg/ruler/ruler.go
@@ -1326,8 +1326,7 @@ func (r *Ruler) ruleGroupListToGroupStateDesc(userID string, backupGroups rulesp
 }
 
 func (r *Ruler) getShardSizeForUser(userID string) int {
-	rulerTenantShardSize := r.limits.RulerTenantShardSize(userID)
-	newShardSize := util.DynamicShardSize(rulerTenantShardSize, r.ring.InstancesCount())
+	newShardSize := util.DynamicShardSize(r.limits.RulerTenantShardSize(userID), r.ring.InstancesCount())
 
 	// We want to guarantee that shard size will be at replication factor
 	return max(newShardSize, r.cfg.Ring.ReplicationFactor)

Original file line number	Diff line number	Diff line change
`@@ -1326,8 +1326,7 @@ func (r *Ruler) ruleGroupListToGroupStateDesc(userID string, backupGroups rulesp`
`1326`	`1326`	`}`
`1327`	`1327`
`1328`	`1328`	`func (r *Ruler) getShardSizeForUser(userID string) int {`
`1329`		`- rulerTenantShardSize := r.limits.RulerTenantShardSize(userID)`
`1330`		`- newShardSize := util.DynamicShardSize(rulerTenantShardSize, r.ring.InstancesCount())`
	`1329`	`+ newShardSize := util.DynamicShardSize(r.limits.RulerTenantShardSize(userID), r.ring.InstancesCount())`
`1331`	`1330`
`1332`	`1331`	`// We want to guarantee that shard size will be at replication factor`
`1333`	`1332`	`return max(newShardSize, r.cfg.Ring.ReplicationFactor)`