Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

helm-rg bounce and wgrep-ag #3

Open
cmccloud opened this issue May 29, 2018 · 4 comments
Open

helm-rg bounce and wgrep-ag #3

cmccloud opened this issue May 29, 2018 · 4 comments

Comments

@cmccloud
Copy link

Really enjoying how this is coming along. Just got the latest build, and I thought that maybe before spending too much more time on helm-rg--bounce, it would be worth it to take a look at how helm-grep-do-ag does it with wgrep-helm. It might be easier to just format helm-rg results appropriately and let wgrep-helm handle it from there. Take care.

@cmccloud
Copy link
Author

Also, bounce seems to fail to read the updated directory in a search that is rerun from a new directory using M-d.

@cosmicexplorer
Copy link
Owner

I'll take a look right now! I would love to contribute to an existing project if possible. "bounce mode" is "experimental" right now, until I add testing (soon, if wgrep-helm works well enough), but I will look into the issue you described with using M-d after that.

@cosmicexplorer
Copy link
Owner

cosmicexplorer commented May 31, 2018

So after looking through wgrep and its frontends, the main issue I see with using that code is that the contents seem to come directly from the command's output, while most of the development on "bounce mode" has been to make it a much more active editing interface, allowing:

  • editing file names
  • expanding the lines before and after just the current line by reading from the source file
  • adding newlines in the edited text
  • re-reading the line contents from a specific file
  • saving the results of a single file without saving all of the rest yet

Most of the "bounce mode" development I see as being something that could be layered on top of wgrep, as I see it, to add this kind of "live editing" or whatever. wgrep seems to have many frontends (including a helm one), but not a ripgrep one, which is very interesting. I'll absolutely keep a close eye on that package -- as of now the current development seems like it might be orthogonal to wgrep and thinking about how this would slot into that is very interesting. Thanks a lot for pointing it out!

@cosmicexplorer
Copy link
Owner

Also, bfc3a16 should have fixed the M-d issue! I just made sure to change to the directory using the variable we're already using for the helm buffer.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants