Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New ripgrep format breaks helm-rg #39

Open
lytex opened this issue Oct 5, 2023 · 1 comment
Open

New ripgrep format breaks helm-rg #39

lytex opened this issue Oct 5, 2023 · 1 comment

Comments

@lytex
Copy link

lytex commented Oct 5, 2023

Ripgrep has changed the format of the urls and this breaks helm-rg.
It now includes hostname and user name

For example the query:
/usr/bin/rg --smart-case --color=ansi --colors=match:fg:red --colors=match:style:bold "empower your writing with emacs org-mode" ~/org

Old format:
�[0m�[35m/home/user/org/roam/20210812120549-literate_programming.org�[0m:** [[https://www.offerzen.com/blog/literate-programming-empower-your-writing-with-emacs-org-mode][Literate Programming: �[0m�[1m�[31mEmpower Your Writing with Emacs Org-Mode�[0m - OfferZen]]


New format:
�]8;;file://hostname/home/user/org/roam/20210812120549-literate_programming.org�\�[0m�[35m/home/user/org/roam/20210812120549-literate_programming.org�[0m�]8;;�\:** [[https://www.offerzen.com/blog/literate-programming-empower-your-writing-with-emacs-org-mode][Literate Programming: �[0m�[1m�[31mEmpower Your Writing with Emacs Org-Mode�[0m - OfferZen]]

This in turn breaks file paths, and helm-rg cannot jump to the right file. Instead it prompts the user to create some jumbled up directory:
home/user/org/�]8;;file://hostname/home/user/org/roam/20210812120549-literate_programming.org�\roam/

Old format:
image

New format:
image

It seems the commit introducing the change is BurntSushi/ripgrep@1a50324

Currently this commit it is not part of a released ripgrep version, but some day it will be the current one.

@lytex
Copy link
Author

lytex commented Mar 30, 2024

There is now a pull request #40, not yet tested

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant