Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Gov tags cleanup #1781

Merged
merged 4 commits into from
Jul 21, 2018
Merged

R4R: Gov tags cleanup #1781

merged 4 commits into from
Jul 21, 2018

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jul 20, 2018

Separate tags into a package to avoid duplicate strings throughout - consistent with tags de# stake - also a teeny bit of non-breaking cleanup

I've labelled as breaking changes, because some of the tag names have changed (one typo, but mostly CamelCase to dash spaces)

  • Updated all relevant documentation (docs/) - NEED TAGS documentation! (just opened Document Module Tags #1780)
  • Updated all relevant code comments
  • n/a Wrote tests
  • Updated PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski added C:x/gov ready-for-review T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jul 20, 2018
@rigelrozanski rigelrozanski requested a review from sunnya97 July 20, 2018 17:00
@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #1781 into develop will increase coverage by 0.68%.
The diff coverage is 70.45%.

@@             Coverage Diff             @@
##           develop    #1781      +/-   ##
===========================================
+ Coverage    62.77%   63.46%   +0.68%     
===========================================
  Files          122      117       -5     
  Lines         7125     6914     -211     
===========================================
- Hits          4473     4388      -85     
+ Misses        2390     2270     -120     
+ Partials       262      256       -6

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, improved!

@cwgoes cwgoes merged commit 17eb3ed into develop Jul 21, 2018
@cwgoes cwgoes deleted the rigel/gov-tags-cleanup branch July 21, 2018 01:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C:x/gov T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants