Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

simulation: Add weighted operation #2303

Merged
merged 2 commits into from
Sep 12, 2018
Merged

simulation: Add weighted operation #2303

merged 2 commits into from
Sep 12, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Sep 10, 2018

The intent of this is to reduce the amount of proposals submitted, to speed up the simulation a bit. At the moment there are too many calls, so its overly computationally intensive. (Especially as each proposals schedules ~50 votes)

This also reduces the number of msg edit validators, since I don't think thats a useful thing for the fuzzer to be spending cycles on.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@fb0cc0b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2303   +/-   ##
==========================================
  Coverage           ?   63.95%           
==========================================
  Files              ?      140           
  Lines              ?     8688           
  Branches           ?        0           
==========================================
  Hits               ?     5556           
  Misses             ?     2756           
  Partials           ?      376

@cwgoes
Copy link
Contributor

cwgoes commented Sep 11, 2018

This is great but I'm going to wait a bit to merge so the existing failing simulation cases we have don't change.

@cwgoes
Copy link
Contributor

cwgoes commented Sep 12, 2018

Merging #2238 so we can merge this now.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit e5e7c4f into develop Sep 12, 2018
@cwgoes cwgoes deleted the dev/sim_weighted_op branch September 12, 2018 07:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants