-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement Fee-Distribution REST #2358
Comments
Change label if you believe this is necessary for Game of Steaks :-) |
Adding prelaunch-2.0 since voyager needs these for its staking2 milestone |
Totally - I'll add this to my todo - the "delegation fee worth" query is not going to be so simple as it needs to replicate some core logic - may actually come paired with a distribution refactor to easily accommodate for the tx as well as query (tx logic wouldn't change) |
Could we come up with the swagger first? Then we can argue about the implementation before needing to change the code. |
Agree with fabo. Let's write down the desired responses to avoid doing refactors and further changes down the road |
hmm yeah I'm only certain that the query need to be implemented which is the complicated part which I should take on - not sure on what other features are required |
implementing the queries now - shortly after the rest can be implemented (ideally somebody else can take that on!) |
what about the swagger description first? :/ |
sounds like a good idea, not totally sure how to take that on.. seems mostly independent of implementing CLI queries which is all I was referencing earlier |
This is blocked on the F1 PR and will be implemented after #3099 is merged. |
This is a prelaunch requirement for Voyager. |
Please implement: https://cosmos.network/rpc/#/ICS24, also we need to bring the CLI up to feature parity with the RPC endpoints mentioned above. |
Apparently specs need update. This is presently blocked. |
Just needs to be done in a separate PR as fee-distribution is getting quite large (#2236)
The text was updated successfully, but these errors were encountered: